Fix deprecation warnings in PhotonLib examples#1699
Merged
mcm001 merged 8 commits intoPhotonVision:mainfrom Jan 12, 2025
DeltaDizzy:fix-photonlib-examples
Merged
Fix deprecation warnings in PhotonLib examples#1699mcm001 merged 8 commits intoPhotonVision:mainfrom DeltaDizzy:fix-photonlib-examples
mcm001 merged 8 commits intoPhotonVision:mainfrom
DeltaDizzy:fix-photonlib-examples
Conversation
Contributor
|
Contributor
Author
Only in photon-lib itself from a quick search (VisionSystemSimTest.cpp L37) |
mcm001
pushed a commit
to mcm001/photonvision
that referenced
this pull request
Feb 18, 2025
The following deprecation warnings have been fixed: - `SwerveModuleState.optimize(desiredState, currentRotation);`, which is now an instance method - `AprilTagFields.kDefaultField.loadAprilTagLayoutField();`, which is now `AprilTagFieldLayout.loadField(AprilTagFields.kDefaultField);` WIP: - [x] C++ - [x] Python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following deprecation warnings have been fixed:
SwerveModuleState.optimize(desiredState, currentRotation);, which is now an instance methodAprilTagFields.kDefaultField.loadAprilTagLayoutField();, which is nowAprilTagFieldLayout.loadField(AprilTagFields.kDefaultField);WIP: